Skip to content

i18n - pulling from tx - #1265

Merged
chris1984 merged 1 commit into
theforeman:developfrom
ogajduse:i18n-r2
Sep 29, 2026
Merged

chris1984 merged 1 commit into
theforeman:developfrom
ogajduse:i18n-r2

Conversation

@ogajduse

Copy link
Copy Markdown
Member

Pulls the second round of Satellite 6.20 / Foreman 5.0 translations from Transifex.

The four languages supported downstream (fr, ja, ko, zh_CN) go from 222 to 247 translated strings each; other languages get whatever the community has contributed since the last pull. The .pot changes only in timestamps and source line references — no strings added or removed.

Extraction and compilation ran in a container with Foreman develop and this plugin mounted (rake plugin:gettext, plugin:po_to_json, make -C locale mo-files).

Satellite 6.20 ships this plugin and needs the translations in a released gem by 2026-10-09 to make snap 07 on 10-13 — a release once this merges would be much appreciated.

Ref: https://issues.redhat.com/browse/SAT-51547

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="app/assets/javascripts/foreman_rh_cloud/locale/fr/foreman_rh_cloud.js" line_range="390" />
<code_context>
+        "N'incluez que les données minimales requises dans les rapports d'inventaire destinés au cloud Red Hat. Dans ce cas, les paquets installés sont exclus du rapport, quel que soit le paramètre `exclude_installed_packages`, et les noms d'hôtes et adresses IPv4 sont exclus, quels que soient les paramètres d'obfuscation. Ces informations sont ignorées lors de l'utilisation d'Insights en local."
</code_context>
<issue_to_address>
**nitpick:** The French description includes literal Markdown backticks around `exclude_installed_packages`, while the translation is rendered as ordinary UI text, so users see the backticks in the setting description even though the source string does not contain them.

**Triggers:** When the French inventory settings description is displayed.

**Suggested fix:** Remove the backticks from the translated string, or render the description through a Markdown-aware component.

```suggestion
        "N'incluez que les données minimales requises dans les rapports d'inventaire destinés au cloud Red Hat. Dans ce cas, les paquets installés sont exclus du rapport, quel que soit le paramètre exclude_installed_packages, et les noms d'hôtes et adresses IPv4 sont exclus, quels que soient les paramètres d'obfuscation. Ces informations sont ignorées lors de l'utilisation d'Insights en local."
```
</issue_to_address>

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@chris1984
chris1984 merged commit c48037a into theforeman:develop Sep 29, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants