Repository navigation
Use Foreman 5.0 RPM repos on 3.3 stable - #921
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dd54b55 to
6ab7775
Compare
|
I did encounter similar issue and ended up with Katello/hammer-cli-katello#1046 |
|
Oh, 2.y-stable also uses nightly repos https://github.com/theforeman/foremanctl/blob/2.y-stable/development/playbooks/setup-repositories/setup-repositories.yaml#L19-L20 , 🙅 |
Yes, I'm going to open another PR for 2.x as well |
|
thanks, i also noticed that we use nightly in packit as well https://github.com/theforeman/foremanctl/blob/3.3-stable/.packit.yml#L16, i think we should also point that to 5.0 |
6ab7775 to
e5adf20
Compare
|
Failed to load packit config file: For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
e5adf20 to
606661f
Compare
I'm afraid this explanation makes no sense. Yes, we're using nightly RPMs for hammer. Yes, it's not ideal, but usually hammer works quite fine with "non matching versions". The error from the linked Which to me indicates a broken nightly repo if the matching hammer versions can't be resolved there? Probably because it ran without Katello/hammer-cli-katello@ce43658? And probably would have happened the very same way if you'd have run it against master that does use nightly. I've re-run the failed test now and it passed the hammer installation just fine. |
evgeni
left a comment
There was a problem hiding this comment.
Don't change trigger: commit in packit
606661f to
526c5a3
Compare
Fixed, only changed the branch for the specfile |
forge setup-repositorieson3.3-stablecurrently defaults the Foreman and Katello RPM repositories tonightly, even though this branch uses Foreman 5.0 container images. The nightly repo has advanced to Katello 5.1, which causes Hammer installation to fail because the requiredhammer_cli_foreman_tasksdependency cannot be resolved.Default the RPM repository version to 5.0 so the development VM uses the release matching the stable image stream. Nightly remains available as an explicit override when testing unreleased packages.
This was found while investigating the failed integration build in pulp-oci-images PR #127.
Validation:
git diff --checkrubygem-hammer_cli_katello5.0.2 and the 5.0 Foreman plugins repo providesrubygem-hammer_cli_foreman_tasks0.0.25.