Skip to content

Use Foreman 5.0 RPM repos on 3.3 stable - #921

Merged
evgeni merged 1 commit into
theforeman:3.3-stablefrom
Odilhao:codex/foremanctl-stable-3.3-repos
Oct 7, 2026
Merged

evgeni merged 1 commit into
theforeman:3.3-stablefrom
Odilhao:codex/foremanctl-stable-3.3-repos

Conversation

@Odilhao

@Odilhao Odilhao commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

forge setup-repositories on 3.3-stable currently defaults the Foreman and Katello RPM repositories to nightly, even though this branch uses Foreman 5.0 container images. The nightly repo has advanced to Katello 5.1, which causes Hammer installation to fail because the required hammer_cli_foreman_tasks dependency cannot be resolved.

Default the RPM repository version to 5.0 so the development VM uses the release matching the stable image stream. Nightly remains available as an explicit override when testing unreleased packages.

This was found while investigating the failed integration build in pulp-oci-images PR #127.

Validation:

  • git diff --check
  • Confirmed the 5.0 Katello repo provides rubygem-hammer_cli_katello 5.0.2 and the 5.0 Foreman plugins repo provides rubygem-hammer_cli_foreman_tasks 0.0.25.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 453ee6f8-94df-4d5a-9b56-37b2c949d6b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Odilhao
Odilhao force-pushed the codex/foremanctl-stable-3.3-repos branch from dd54b55 to 6ab7775 Compare October 6, 2026 19:28
@arvind4501

Copy link
Copy Markdown
Contributor

I did encounter similar issue and ended up with Katello/hammer-cli-katello#1046

@arvind4501

Copy link
Copy Markdown
Contributor

@Odilhao

Odilhao commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

Oh, 2.y-stable also uses nightly repos https://github.com/theforeman/foremanctl/blob/2.y-stable/development/playbooks/setup-repositories/setup-repositories.yaml#L19-L20 , 🙅

Yes, I'm going to open another PR for 2.x as well

@arvind4501

Copy link
Copy Markdown
Contributor

thanks, i also noticed that we use nightly in packit as well https://github.com/theforeman/foremanctl/blob/3.3-stable/.packit.yml#L16, i think we should also point that to 5.0

@Odilhao
Odilhao force-pushed the codex/foremanctl-stable-3.3-repos branch from 6ab7775 to e5adf20 Compare October 6, 2026 21:56
@packit-as-a-service

Copy link
Copy Markdown

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {1: {'packages': defaultdict(<class 'dict'>, {'foremanctl': {'value': {'project': ['Not a valid string.']}}})}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command config validate or our pre-commit hooks for validation of the configuration.

@Odilhao
Odilhao force-pushed the codex/foremanctl-stable-3.3-repos branch from e5adf20 to 606661f Compare October 6, 2026 22:09
Comment thread .packit.yml Outdated
@evgeni

evgeni commented Oct 7, 2026

Copy link
Copy Markdown
Member

forge setup-repositories on 3.3-stable currently defaults the Foreman and Katello RPM repositories to nightly, even though this branch uses Foreman 5.0 container images. The nightly repo has advanced to Katello 5.1, which causes Hammer installation to fail because the required hammer_cli_foreman_tasks dependency cannot be resolved.

I'm afraid this explanation makes no sense.

Yes, we're using nightly RPMs for hammer. Yes, it's not ideal, but usually hammer works quite fine with "non matching versions".

The error from the linked pulp-oci-images PR is:

nothing provides (rubygem(hammer_cli_foreman_tasks) >= 0.0.20 with rubygem(hammer_cli_foreman_tasks) < 0.1) needed by rubygem-hammer_cli_katello-5.1.0-0.1.pre.main.20261005082529git751c86a.el10.noarch from katello

Which to me indicates a broken nightly repo if the matching hammer versions can't be resolved there? Probably because it ran without Katello/hammer-cli-katello@ce43658? And probably would have happened the very same way if you'd have run it against master that does use nightly.

I've re-run the failed test now and it passed the hammer installation just fine.

@evgeni evgeni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change trigger: commit in packit

@Odilhao
Odilhao force-pushed the codex/foremanctl-stable-3.3-repos branch from 606661f to 526c5a3 Compare October 7, 2026 12:09
@Odilhao

Odilhao commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Don't change trigger: commit in packit

Fixed, only changed the branch for the specfile

@Odilhao
Odilhao requested a review from evgeni October 7, 2026 12:13
@evgeni
evgeni merged commit 73c0298 into theforeman:3.3-stable Oct 7, 2026
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants