Skip to content

feat(iop): enable exploits and rules sync (flavor) - #927

Open
vkrizan wants to merge 1 commit into
theforeman:masterfrom
vkrizan:enable-exploits-sync-sat-flavor
Open

vkrizan wants to merge 1 commit into
theforeman:masterfrom
vkrizan:enable-exploits-sync-sat-flavor

Conversation

@vkrizan

@vkrizan vkrizan commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Why are you introducing these changes? (Problem description, related links)

Satellite flavor needs to explicitly enable sync of exploits data and rules metadata.

What are the changes introduced in this pull request?

Sets iop_vulnerability_taskomatic_jobs and iop_vulnerability_taskomatic_startup variables to additionally run exploit_sync and rules_git_sync jobs in IoP Vulnerability Taskomatic.

How to test this pull request

Steps to reproduce:

  • Deploy with satellite flavor
  • Check the service unit of iop-service-vuln-taskomatic.service that it includes exploit_sync and rules_git_sync jobs in env vars.
  • Check logs of the taskomatic that it runs these jobs on startup.

Checklist

  • Tests added/updated (if applicable)
  • Documentation updated (if applicable)

Sets iop_vulnerability_taskomatic_jobs and
iop_vulnerability_taskomatic_startup to do exploit_sync and rules_git_sync.
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 33581741-061f-4765-96e6-f3c169f57ee8

📥 Commits

Reviewing files that changed from the base of the PR and between 647887b and 44deacd.


📒 Files selected for processing (1)
  • src/vars/flavors/satellite.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

The Satellite flavor now configures vulnerability taskomatic job intervals and startup jobs.

Changes

Satellite vulnerability jobs

Layer / File(s) Summary
Configure vulnerability job schedules
src/vars/flavors/satellite.yml
Sets schedules for stale_systems, delete_systems, cacheman, exploit_sync, and rules_git_sync. Sets startup jobs to cacheman, exploit_sync, and rules_git_sync.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature


Merge Risk: ⚪ Minimal · up to 44dea

The Satellite flavor schedules both synchronization jobs daily and includes them at startup. The reviewed configuration presents no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check Passed The description clearly explains that the Satellite flavor enables the exploit and rules synchronization jobs. It also describes the configuration changes and testing steps.
Title check Passed The title clearly identifies the feature change: enabling exploit and rules synchronization for the flavor.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vkrizan

vkrizan commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

@ehelms @jeremylenz please review

@ehelms

ehelms commented Oct 10, 2026

Copy link
Copy Markdown
Member

Why are these special to the flavor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants