refactor: drop --force flag from tag command#329
Open
pat-s wants to merge 1 commit into
Open
Conversation
The `--force`/`-f` flag on `git sv tag` is effectively useless: the tag handler always computes the next version, so it never re-tags an existing one and force has no effect. Remove the flag and the TagSettings.Force field. The underlying Tag() force capability is retained for the dedicated retag command. Refs thegeeklab#306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--force/-fflag ongit sv tagis effectively useless: the tag handler always computes the next version, so it never re-tags an existing one and force has no effect.Refs #306