Repository navigation
Conversation
traits_for_enum used `value || trait_name` when building traits from a Hash, so a false value was replaced by the trait name. Use an explicit nil check so Array-style entries still fall back to the trait name while false is kept.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
traits_for_enumbuilds traits from a Hash with:Because
falseis falsy in Ruby, a mapping like{ draft: false, published: true }set the attribute to the trait name (:draft) instead offalse.Array-style values still need the
nilfallback so a bare list of names keeps using the name as the attribute value.Fix
Use an explicit
nil?check:Test
Added an acceptance example that uses
{ draft: false, published: true }and asserts each trait assigns the exact boolean.