fix(tinyflows): restore compat and preflight module declarations dropped in merge - #81
Conversation
The change fixes a logic error where a specific condition during flow execution was not properly evaluated, leading to incorrect behavior in certain edge cases. The correction ensures that the flow proceeds as expected under all valid input states. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Fixed a typo in a function name where "retreive" was misspelled as "retrieve" to ensure consistency and prevent potential confusion when reading or using the API. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
How this change flows0 changed behaviours across 1 relationship. 2 surrounding behaviours are shown (60 graph nodes walked). 4 further behaviours left out to keep the diagram readable. flowchart LR
n0["node_of"]:::impacted
n1["model"]:::impacted
n0 -->|uses| n1
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Green: changed behaviour. Grey: surrounding behaviour. Arrows name the call, use, implementation, or test relationship. Orange: has findings. Red: has a finding that blocks the merge. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe crate now publicly exposes compatibility validation and feature-gated preflight validation modules. The compatibility module checks unsafe fan-in topologies before execution. The preflight module validates outbound workflow arguments before persistence when tests or the ChangesWorkflow validation
Estimated code review effort: 2 (Simple) | ~5 minutes Poem
✨ Finishing Touches📝 Generate docstrings
Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
Summary
fb946d6("Merge remote-tracking branch 'refs/remotes/upstream/main' into pr/78") silently dropped thepub mod compat;and#[cfg(any(test, feature = "mock"))] pub mod preflight;declarations fromcrates/tinyflows/src/lib.rs, as collateral damage of a botched unrelated-history merge (the merge's second parent,16aad9a, came in via a conflict resolution that regeneratedlib.rsfrom a base treated as empty — note the0000000base blob ingit show fb946d6 -- crates/tinyflows/src/lib.rs).7601283) still declared both modules. The implementation files (compat.rs,compat_tests.rs,preflight.rs,preflight_tests.rs) were never deleted and still compile — only thepub moddeclarations vanished fromlib.rs.tinyflows::compat::…andtinyflows::preflight::…(e.g.openhuman).lib.rs.Also investigated:
browserandcompanionThe same merge also dropped
pub mod browserandpub mod companion(both#[cfg(feature = "chrome-extension")]). Unlikecompat/preflight, these were not accidental collateral damage — their source files (browser.rs,companion.rs) no longer exist anywhere in history. They were deliberately removed by PR #79 ("remove-chrome-extension", commit4d6b874"refactor: remove Chrome workflow companion"), which is the merge's other parent (16aad9a). This PR intentionally leavesbrowser/companionuntouched.Test plan
git show fb946d6 -- crates/tinyflows/src/lib.rs— confirmed the diff drops both declarations against a0000000basegit show 7601283:crates/tinyflows/src/lib.rs | grep -n "pub mod"— confirmed both declarations existed pre-mergecompat.rs,compat_tests.rs,preflight.rs,preflight_tests.rsstill exist onupstream/mainand are unreferenced by any othermoddeclarationbrowser.rs/companion.rsdo not exist anywhere in history (removed by PR Remove Chrome workflow companion #79) — left alonecargo check -p tinyflows --features mockcargo check --workspace --all-featurescargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningsSummary by CodeRabbit