Repository navigation
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Tiny Sweeper reviewTiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Incomplete Review snapshot
Completeness: Incomplete FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred.
Findings
Could not review: crates/tinyhivemind-openhuman/Cargo.toml, crates/tinyhivemind-openhuman/examples/live_language/test.rs, crates/tinyhivemind-openhuman/src/config/test/mod.rs, deny.toml, tinysweeper/description, tinysweeper/tests Before merge
How this fits togetherflowchart LR
n0["run_with_mcp_executable"]:::impacted
n1["run_with_mcp_executable_and_timeout"]:::impacted
n2["Task"]:::impacted
n0 -->|calls| n1
n0 -->|tests| n1
n0 -->|uses| n2
n1 -->|uses| n2
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
|
Warning Review limit reached
This review includes 161 billable files and costs up to $40.25. View limit details
Comment |
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: Cargo.toml, ROADMAP.md, crates/tinyhivemind-core/src/driver/conduct/test/wire.rs, crates/tinyhivemind-core/src/driver/conduct/types.rs, crates/tinyhivemind-core/src/hive/division/test.rs, crates/tinyhivemind-core/src/hive/division/types.rs, crates/tinyhivemind-hives/src/README.md, crates/tinyhivemind-hives/src/coordinator/README.md and 150 more.
$0.0016 · 194,394 in / 3,946 out · 128 cached (0%) · glm-5.3-flash
Co-authored-by: Medulla <medulla@tinyhumans.ai>
# Conflicts: # crates/tinyhivemind-openhuman/README.md
Co-authored-by: Medulla <medulla@tinyhumans.ai>
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: crates/tinyhivemind-openhuman/src/config/test/directory.rs, deny.toml, tinysweeper/description, tinysweeper/tests.
$0.1092 · 893,465 in / 26,137 out · 404,801 cached (45%) · flash, openai/gpt-5.6-luna, deep, , z-ai/glm-5.3-flash
critique: $0.0505 · 192,081 in / 6,778 out · 19,566 cached (10%) · openai/gpt-5.6-luna, deep
security: $0.0346 · 135,843 in / 3,897 out · 13,389 cached (10%) · openai/gpt-5.6-luna, , deep
There was a problem hiding this comment.
Requesting changes: 1 lane(s) blocking, worst finding is critical.
Fix or reply to the findings below and push. The next review clears this automatically once they are gone — you should not need to dismiss anything by hand.
$0.0759 · 578,752 in / 17,567 out · 184,742 cached (32%) · openai/gpt-5.6-luna, , deep, deepseek/deepseek-v4-flash
critique: $0.0272 · 99,593 in / 4,420 out · 9,846 cached (10%) · openai/gpt-5.6-luna, , deep
security: $0.0281 · 105,961 in / 4,040 out · 11,078 cached (10%) · openai/gpt-5.6-luna, , deep
The sole finding is a false positive: crates/tinyhivemind-openhuman/src/config/test/fixtures/full.json is committed at the reviewed head and the relative include_str path resolves to it. I replied to the inline thread with git evidence; no code fix is applicable. A re-request was attempted, but GitHub could not resolve the tinysweeper reviewer login. Dismissing only this review after verifying the finding is incorrect.
Summary
Replace hand-built OpenHuman seats with a validated manifest and a deployment that constructs one runtime, reusable profiles, continuing seats, and multiple hives. Refresh the vendored embed pin to
bc59324d, migrate the three existing examples, and add an offline multi-hive proof where one seat writes in hive A and is refused in hive B without changing its session.Related issue
Closes #113. Closes #114. Closes #115. Closes #116. Closes #117. Closes #118.
API or behavior changes
turn_idand optional scheduled origin fields to public turn/storage types. Persisted additions use serde defaults; Rust struct literals must be updated. Add the providedTurnHooks::turn_timeoutmethod and await native cancellation cleanup.Validation
Commands actually run, with their outcome:
cargo fmt --all -- --check— passedcargo clippy --all-targets --all-features -- -D warnings— passedcargo build --all-targets --all-features— passedcargo test --all-features— passed.github/scripts/assert-pure.shand.github/scripts/assert-openhuman-pin.sh— passedRUSTDOCFLAGS="-D warnings" cargo doc --no-deps --all-features— passedcargo fmt --manifest-path examples/openhuman/Cargo.toml --all -- --check— passedcargo clippy --manifest-path examples/openhuman/Cargo.toml --all-targets -- -D warnings— passedcargo build --manifest-path examples/openhuman/Cargo.toml --all-targets— passedcargo test --manifest-path examples/openhuman/Cargo.toml— passed: 73 tests, no failures or ignored testscargo run --manifest-path examples/openhuman/Cargo.toml --bin basic_hiveand--bin multi_hive— both offline runs passedcargo llvm-cov --workspace --all-features --json --output-path target/workspace-coverage-final.json— passed; all 28 changed executable library source files exceed 90% line coverage (minimum 92.1%). Standalone executable source coverage was not measured.These checks ran after merging the latest upstream main, including its hive-language changes.
CI follow-up
The initial CI run found two supply-chain findings and two coverage-short test files. The latest commit adds a package-scoped
MIT-0exception forborrow-or-share 0.2.4, skips only the manifest-level wildcard finding for the revision-pinnedtinyflows-sqlite 0.1.0, and changes fixture tests to propagate setup errors.cargo deny check all, strict Clippy, and focused OpenHuman coverage pass locally; both affected test files now exceed 95% coverage. The branch also includes upstream #121, merged during review, with both README topics retained. CI is rerunning on the updated head.Tests
Regression tests cover strict manifests, independent blind/revealed widths, README exclusion, layered permissions, authenticated MCP/delegate/management effects, continuing sessions, native subprocess cleanup, premature/stale approval release, and overlapping workflow invocation identities. Tests for the four checked-in manifests inspect native lowering as well as metadata. Offline basic and multi-hive runs exercise the actual deployment.
Live provider, real Docker, and operator credential integrations are optional and were not run. Automated pin-refresh scheduling remains the explicit open question; this change refreshes the pin on demand.
Documentation
Accepted behavior and native limits:
docs/specs/openhuman-hive-config.md; implementation record:docs/plans/2026-10-10-openhuman-hive-config.md. Update adapter/module documentation, checked-in example manifest documentation, ROADMAP, and the wiki host-integration page. The wiki commit is pushed to its canonical repository on the matching branch and included through the gitlink.Checklist
#[allow(...)],#[ignore], or relaxed lints.envcontents in the diff or the description