Skip to content

chore: deprecate FunC and Tact templates#57

Merged
i582 merged 1 commit into
masterfrom
danil42russia/deprecated
Jun 27, 2026
Merged

chore: deprecate FunC and Tact templates#57
i582 merged 1 commit into
masterfrom
danil42russia/deprecated

Conversation

@Danil42Russia

@Danil42Russia Danil42Russia commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Issue

Closes #

Checklist

Please ensure the following items are completed before requesting review:

  • Updated CHANGELOG.md with relevant changes
  • Documented the contribution in README.md
  • Added tests to demonstrate correct behavior (both positive and negative cases)
  • All tests pass successfully (yarn test)
  • Code passes linting checks (yarn lint)

Summary by CodeRabbit

  • Documentation
    • Updated the project creation docs to clearly mark older contract type options as deprecated.
  • New Features
    • Updated the CLI template list so deprecated FunC and Tact variants are labeled as such in the prompt, while behavior remains unchanged.

@Danil42Russia Danil42Russia requested a review from i582 June 26, 2026 11:08
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR updates the CLI template names and README --type documentation to mark the FunC and Tact empty and counter options as deprecated, while keeping the underlying values unchanged.

Changes

Deprecated template labels

Layer / File(s) Summary
Template labels and docs
src/main.ts, README.md
The human-readable variant names and README --type list now mark the FunC and Tact empty and counter options as deprecated; the stored values remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny hopped by, ears all a-flutter,
“Deprecated,” said I, with a README mutter.
Tact and FunC now wear a small sign,
While values stay steady, neat and fine.
Hop hop — the template trail shines! 🐰

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is mostly a copied template and lacks the actual issue number and completed checklist details, so it is too generic. Replace the placeholder issue reference with the real number and fill out the checklist with the actual changelog, README, tests, and lint status.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: deprecating the FunC and Tact templates.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch danil42russia/deprecated

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/main.ts`:
- Around line 30-46: The contract template list in main.ts is inconsistent with
the PR intent: the deprecated labels are currently applied to func-* and tact-*
entries while tolk-* entries remain active. Update the template names in the
relevant options list to match the intended deprecation policy, or if Tolk
should stay active, adjust the PR title/description accordingly; use the
existing template value symbols like func-empty, tact-empty, tolk-empty,
func-counter, tact-counter, and tolk-counter to verify the correct variants are
labeled deprecated.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 64c4a5af-0eff-4fe6-a72c-53c277d7350b

📥 Commits

Reviewing files that changed from the base of the PR and between 9ea3fec and e5dcb7d.

📒 Files selected for processing (2)
  • README.md
  • src/main.ts

Comment thread src/main.ts
Comment on lines +30 to +46
name: 'An empty contract (FunC, deprecated)',
value: 'func-empty',
},
{
name: 'An empty contract (Tact)',
name: 'An empty contract (Tact, deprecated)',
value: 'tact-empty',
},
{
name: 'A simple counter contract (Tolk)',
value: 'tolk-counter',
},
{
name: 'A simple counter contract (FunC)',
name: 'A simple counter contract (FunC, deprecated)',
value: 'func-counter',
},
{
name: 'A simple counter contract (Tact)',
name: 'A simple counter contract (Tact, deprecated)',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify all variant references across the codebase to check consistency
rg -n 'tolk-empty|tolk-counter|func-empty|func-counter|tact-empty|tact-counter' --type=ts --type=md

Repository: ton-org/create-ton

Length of output: 156


Discrepancy: PR title claims "FunC, Tolk" deprecation, but code marks "FunC, Tact" as deprecated.

The code in src/main.ts (lines 30–47) explicitly marks func-* and tact-* variants as deprecated, while tolk-empty and tolk-counter remain active without the "deprecated" label.

Verify the intent:

  1. If Tolk contracts are intended to be deprecated, update their names to include the "(deprecated)" label.
  2. If Tact contracts are intended for deprecation and Tolk should remain, correct the PR title and description to reflect "FunC, Tact".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main.ts` around lines 30 - 46, The contract template list in main.ts is
inconsistent with the PR intent: the deprecated labels are currently applied to
func-* and tact-* entries while tolk-* entries remain active. Update the
template names in the relevant options list to match the intended deprecation
policy, or if Tolk should stay active, adjust the PR title/description
accordingly; use the existing template value symbols like func-empty,
tact-empty, tolk-empty, func-counter, tact-counter, and tolk-counter to verify
the correct variants are labeled deprecated.

@i582 i582 changed the title chore: deprecated FunC, Tolk contracts chore: deprecated FunC and Tact templates Jun 27, 2026
@i582 i582 changed the title chore: deprecated FunC and Tact templates chore: deprecate FunC and Tact templates Jun 27, 2026
@i582 i582 merged commit 847147f into master Jun 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants