chore: deprecate FunC and Tact templates#57
Conversation
📝 WalkthroughWalkthroughThe PR updates the CLI template names and README ChangesDeprecated template labels
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main.ts`:
- Around line 30-46: The contract template list in main.ts is inconsistent with
the PR intent: the deprecated labels are currently applied to func-* and tact-*
entries while tolk-* entries remain active. Update the template names in the
relevant options list to match the intended deprecation policy, or if Tolk
should stay active, adjust the PR title/description accordingly; use the
existing template value symbols like func-empty, tact-empty, tolk-empty,
func-counter, tact-counter, and tolk-counter to verify the correct variants are
labeled deprecated.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| name: 'An empty contract (FunC, deprecated)', | ||
| value: 'func-empty', | ||
| }, | ||
| { | ||
| name: 'An empty contract (Tact)', | ||
| name: 'An empty contract (Tact, deprecated)', | ||
| value: 'tact-empty', | ||
| }, | ||
| { | ||
| name: 'A simple counter contract (Tolk)', | ||
| value: 'tolk-counter', | ||
| }, | ||
| { | ||
| name: 'A simple counter contract (FunC)', | ||
| name: 'A simple counter contract (FunC, deprecated)', | ||
| value: 'func-counter', | ||
| }, | ||
| { | ||
| name: 'A simple counter contract (Tact)', | ||
| name: 'A simple counter contract (Tact, deprecated)', |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify all variant references across the codebase to check consistency
rg -n 'tolk-empty|tolk-counter|func-empty|func-counter|tact-empty|tact-counter' --type=ts --type=mdRepository: ton-org/create-ton
Length of output: 156
Discrepancy: PR title claims "FunC, Tolk" deprecation, but code marks "FunC, Tact" as deprecated.
The code in src/main.ts (lines 30–47) explicitly marks func-* and tact-* variants as deprecated, while tolk-empty and tolk-counter remain active without the "deprecated" label.
Verify the intent:
- If Tolk contracts are intended to be deprecated, update their names to include the "(deprecated)" label.
- If Tact contracts are intended for deprecation and Tolk should remain, correct the PR title and description to reflect "FunC, Tact".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/main.ts` around lines 30 - 46, The contract template list in main.ts is
inconsistent with the PR intent: the deprecated labels are currently applied to
func-* and tact-* entries while tolk-* entries remain active. Update the
template names in the relevant options list to match the intended deprecation
policy, or if Tolk should stay active, adjust the PR title/description
accordingly; use the existing template value symbols like func-empty,
tact-empty, tolk-empty, func-counter, tact-counter, and tolk-counter to verify
the correct variants are labeled deprecated.
FunC, Tolk contractsFunC and Tact templates
FunC and Tact templatesFunC and Tact templates
Issue
Closes #
Checklist
Please ensure the following items are completed before requesting review:
CHANGELOG.mdwith relevant changesREADME.mdyarn test)yarn lint)Summary by CodeRabbit