Skip to content

♻️ refactor(plugin): name loader entry point - #220

Merged
gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/public-patch-entrypoint
Nov 13, 2026
Merged

gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/public-patch-entrypoint

Conversation

@gaborbernat

@gaborbernat gaborbernat commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Since the simplint adoption, the .pth loader called the private _patch() function. 🔧 It now calls patch(), a public-spelled entry point in the same private module, and the module's __all__ lists it. The package root exports are unchanged.

The health check again reads pre-commit's pyvenv config through its _read_pyvenv_cfg, replacing the local copy of that parser that #217 added; a narrow inline ignore covers the private access, because pre-commit has no public parser. _health_check stays private.

@gaborbernat gaborbernat added enhancement New feature or request skip news No user-facing changelog entry is needed labels Nov 13, 2026
@gaborbernat
gaborbernat force-pushed the fix/public-patch-entrypoint branch from 60b09af to 9fb49e0 Compare November 13, 2026 01:07
The startup loader called a private name across modules after the hook
moved out of the package root. Give that loader an entry point within
the private module and keep the health check internal. Reuse pre-commit's
pyvenv.cfg parser. Reload pre-commit before the plug-in in the install
test so a prior patch cannot become its own original function.
@gaborbernat gaborbernat changed the title ♻️ refactor(plugin): name shared entry points ♻️ refactor(plugin): name loader entry point Nov 13, 2026
@gaborbernat
gaborbernat force-pushed the fix/public-patch-entrypoint branch from 9fb49e0 to 640d488 Compare November 13, 2026 01:23
@gaborbernat
gaborbernat merged commit d95d879 into tox-dev:main Nov 13, 2026
19 checks passed
@gaborbernat
gaborbernat deleted the fix/public-patch-entrypoint branch November 16, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request skip news No user-facing changelog entry is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant