feat: reusable data table list view with design-token fixes - #452
Closed
esafwan wants to merge 4 commits into
Closed
feat: reusable data table list view with design-token fixes#452esafwan wants to merge 4 commits into
esafwan wants to merge 4 commits into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataListViewcomponent (frontend/src/components/dashboard/DataListView.tsx) generalizing the TanStack-table shape used by the Huf Data Table list and Executions pages, so future HUF list pages can reuse it.rounded-md/bg-mutedwith HUF'srounded-none/border-line/bg-panel/text-steeltokens.get_table_recordsmethod using Frappe'ssearch_fields/or_filters).Deliberately deferred to a follow-up phase (not missed): grid/thumbnail display mode, column resize, inline cell edit, row multi-select.
Screenshot (live bench)
Test plan
yarn typecheck— 0 errorsyarn lint— 0 errors (60 pre-existing unrelated warnings)DataListViewshape is suitable for later reuse by Executions.tsx (not migrated in this PR)