feat: add table group field for organizing and filtering Huf Data Tables - #459
Closed
esafwan wants to merge 6 commits into
Closed
feat: add table group field for organizing and filtering Huf Data Tables#459esafwan wants to merge 6 commits into
esafwan wants to merge 6 commits into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
table_groupstring field (label: "Group") to the Huf Data Table registry doctype — a user-chosen label, not a fixed enum or a separate management doctype (deliberately kept simple per the request: "group name it chooses").<datalist>) with a small "Existing groups: ..." hint below it, so you can reuse a group instead of retyping it, while still being free to type a new one.ToolCreationForm.tsx's "Additional Settings" section) to both the Table Settings panel and the Field Properties panel — not every field is equally important, so they shouldn't look equally prominent. Table Name/Description (and Label, for a field) stay full-size and up top; Group/Icon/Naming Method (and Default Value/Help Text/Properties, for a field) — things that default sensibly and are rarely touched — now sit under a smaller, muted "ADDITIONAL SETTINGS" heading with more compact inputs.Note for reviewers: this PR and #458 (builder-form-ux) both touch
TableSettingsPanel.tsx/FieldConfigPanel.tsxindependently (branched from the same base before either merged) — expect a rebase/merge-order conversation before both land.Screenshots (live bench, before → after)
Before (flat list, all under implicit grouping):

After — grouped view (Customers set to group "Sales", Students remains "Ungrouped"):

Toggle — simple view (default when table count is small):

Toggle — grouped view (switched manually):

Group field autosuggest:

Visual hierarchy — Table Settings (primary fields up top, secondary under "ADDITIONAL SETTINGS"):

Visual hierarchy — Field Properties (Label primary, Default/Help Text/Properties demoted):

Test plan
yarn typecheck— 0 errorsyarn lint— 0 errors (60 pre-existing unrelated warnings)