Repository navigation
DEL-2538: Add metric for commit conflicts in ingestor - #23
rishiraj-tf wants to merge 1 commit into
Conversation
The commit loop can report retries, rebases, aborts, and exhausted attempts without taking a Prometheus dependency. Co-authored-by: Cursor <cursoragent@cursor.com>
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 754c915. Configure here.
| error, | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
Create-race conflict skips observer
Low Severity
A lost race on the initial version-0 put is a VersionAlreadyExists retry, but it never calls notify_commit_conflict. The handler still consumes an attempt and continues the retry loop, so table-creation conflicts are omitted from observer counts that the other version-already-exists path records.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 754c915. Configure here.


Summary
tf-0.32.4commit retry loop so callers can count conflicts without a Prometheus dependency in delta-rs.Test plan
cargo test -p deltalake-core --lib installed_observer_counts_one_notificationdf_delta_log_commit_conflict_totalon/metricsMade with Cursor
Note
Low Risk
Observability-only hooks on existing conflict/retry paths; commit behavior is unchanged when no observer is registered.
Reviewed by Cursor Bugbot for commit 754c915. Bugbot is set up for automated code reviews on this repo. Configure here.