fix(android): add ANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON for 16KB page size compliance - #4816
Open
kushdab wants to merge 1 commit into
Open
fix(android): add ANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON for 16KB page size compliance#4816kushdab wants to merge 1 commit into
kushdab wants to merge 1 commit into
Conversation
…e size compliance Google Play now requires all apps targeting Android 15 (API 35) to support 16KB memory page sizes. Without this flag the native libTrustWalletCore.so fails alignment verification, blocking updates. Fixes trustwallet#4643
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4643.
Google Play Store requires all apps targeting Android 15 (API 35) to support 16KB memory page sizes. Without the
-DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ONCMake flag, the nativelibTrustWalletCore.sofails the 16KB page alignment check and apps integrating wallet-core cannot publish updates.Change
Adds the CMake flag to
android/wallet-core/build.gradle:This is the recommended approach from the Android developer docs for enabling flexible page size support in NDK/CMake builds.
Testing
After this change, building the Android library and running the 16KB page size verification tool (
adb shell "/data/local/tmp/page_size_compat_test") should pass forarm64-v8abuilds.