Skip to content

Fix inductor max current rating - #3177

Merged
seveibar merged 1 commit into
tscircuit:mainfrom
rushabhcodes:fix-inductor-max-current-rating
Aug 12, 2026
Merged

Fix inductor max current rating#3177
seveibar merged 1 commit into
tscircuit:mainfrom
rushabhcodes:fix-inductor-max-current-rating

Conversation

@rushabhcodes

Copy link
Copy Markdown
Contributor

Summary

  • Preserve maxCurrentRating when rendering an inductor source component.
  • Convert values such as "2A" to the numeric Circuit JSON value 2.
  • Add regression coverage for the generated source component.

Root cause

The inductor prop was accepted but omitted from the source component insert payload.

Validation

  • bun test tests/components/normal-components/inductor.test.tsx passes.
  • bunx tsc --noEmit remains blocked by existing unrelated type errors in other files.

@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview Aug 12, 2026 4:17pm

Request Review

@rushabhcodes
rushabhcodes marked this pull request as ready for review August 12, 2026 16:21
Copilot AI lite review requested due to automatic review settings August 12, 2026 16:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@seveibar
seveibar merged commit edbdd8a into tscircuit:main Aug 12, 2026
20 of 39 checks passed
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants