Fix copper pour bounds for offset boards - #3178
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
force-pushed
the
agent/fix-offset-board-copper-pour-bounds
branch
from
August 13, 2026 22:06
859f5e8 to
655cea2
Compare
seveibar
marked this pull request as ready for review
August 13, 2026 22:10
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pcb_boardcenter, width, and heightRoot cause
When a rectangular board used
boardAnchorPosition, the renderedpcb_board.centermoved away from(0, 0). Copper-pour rendering leftoutlineundefined, so the solver synthesized bounds as-width / 2 ... width / 2and-height / 2 ... height / 2, ignoring the board center. The pour therefore stayed centered on the origin instead of following the board.Impact
Automatic copper pours now follow rectangular boards whose center is offset, including boards positioned with
boardAnchorPosition. Existing explicit pour and polygon board outlines remain authoritative.Validation
11, received-9bunx tsc --noEmitbun run build