Repository navigation
fix(prom): increment request_fail_count on errored results - #765
Open
vulragrag-star wants to merge 1 commit into
Open
vulragrag-star wants to merge 1 commit into
vulragrag-star wants to merge 1 commit into
Conversation
WithLabelValues alone registers the label set but never bumps the counter, so request_fail_count stayed at zero for every failed request. Call Inc after selecting the labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Fixes #750
Metrics.ObservecalledWithLabelValuesonrequest_fail_countwhenres.Errorwas set, but never.Inc(). That registers the label set (so the metric appears in scrapes) while leaving the counter at zero for every failed request.Checklist
Testing
go test ./lib/prom/ -count=1passesTestMetrics_Observe_FailCounterIncrementedfails onmaster(got 0, want 2) and passes with this change