fix: sign sparkle nested executables with secure timestamps - #34
Merged
Conversation
Notarization rejected the first submission over Sparkle's bare Autoupdate helper (unsigned-by-us, no timestamp) — a find for *.xpc and *.app misses a bare executable, and no codesign call carried --timestamp. Sign Sparkle inside-out per its distribution docs with timestamps everywhere. This exact recipe was verified against the notary service: submission 9d83e166, status Accepted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes #33 — this part of the proven signing recipe was accidentally left uncommitted when #33 merged (caught before any release:
build:cuts none).Notarization rejected Sparkle's bare
Autoupdatehelper (not matched by the*.xpc/*.appfind, and no--timestampanywhere). Now signed inside-out per Sparkle's docs, timestamps on every invocation. This exact recipe passed the notary service locally: submission9d83e166— Accepted.Merging this cuts the first signed + notarized release.
🤖 Generated with Claude Code