Skip to content

core: load user system config - #319

Merged
tingerrr merged 3 commits into
typst-community:mainfrom
T1mVo:system-config
Sep 5, 2026
Merged

tingerrr merged 3 commits into
typst-community:mainfrom
T1mVo:system-config

Conversation

@T1mVo

@T1mVo T1mVo commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

See commit messages.

Prior work for #315

Checklist

  • I have structured my commits according to the commit guidelines (if applicable).
  • I have added tests for new features (if applicable).
  • I have updated the documentation (if applicable).

@T1mVo

T1mVo commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@tingerrr I don't think there's much work to do here, but please have a look at whether SystemConfig should be attached to Project or rather somewhere else.

@tingerrr

tingerrr commented Sep 1, 2026

Copy link
Copy Markdown
Member

[...] I don't think there's much work to do here, but please have a look at whether SystemConfig should be attached to Project or rather somewhere else.

I think it's fine to add to Project since it is currently treated like a context object for commands that operate inside an active Typst project.

@T1mVo
T1mVo force-pushed the system-config branch 2 times, most recently from b66ced7 to 5107891 Compare September 2, 2026 20:27
@T1mVo
T1mVo marked this pull request as ready for review September 2, 2026 20:30
@T1mVo

T1mVo commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

I've renamed config to project_config in most places. I can drop that commit, though, if this doesn't seem right.

The pipeline failed for some reason, but a rerun might already fix it.

@tingerrr

tingerrr commented Sep 3, 2026

Copy link
Copy Markdown
Member

The pipeline failed for some reason, but a rerun might already fix it.

Yes, that one job is fairly flaky.

Could you use just project: for the commit descriptions? I don't find conventional commits to be all that useful.

The rest looks good.

Test `system_config_is_collected()` does test for a empty system config for
now. Config options might be added here later.
@T1mVo

T1mVo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Done

@tingerrr
tingerrr merged commit 9ec166c into typst-community:main Sep 5, 2026
15 checks passed
@tingerrr

tingerrr commented Sep 5, 2026

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants