Skip to content

Remove no inference marker in stub files - #455

Merged
yuxincs merged 4 commits into
mainfrom
yuxincs/remove-no-infer
Jul 29, 2026
Merged

Remove no inference marker in stub files#455
yuxincs merged 4 commits into
mainfrom
yuxincs/remove-no-infer

Conversation

@yuxincs

@yuxincs yuxincs commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This PR removes the nilaway no inference marker in stub files in testdata, as an initial step to eventually remove no infer mode.

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.63%. Comparing base (86401c8) to head (5c370e9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   87.64%   87.63%   -0.02%     
==========================================
  Files          79       79              
  Lines        9542     9542              
==========================================
- Hits         8363     8362       -1     
- Misses        936      937       +1     
  Partials      243      243              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

Golden Test

Note

✅ NilAway errors reported on standard libraries are identical.

2223 errors on base branch (main, 86401c8)
2223 errors on test branch (bf7d89b)

@yuxincs
yuxincs force-pushed the yuxincs/remove-no-infer branch 2 times, most recently from 2a44a75 to 4a7a98d Compare July 29, 2026 15:17
@yuxincs yuxincs changed the title Remove NoInfer mode and re-organize testdata Remove no inference marker in stub files Jul 29, 2026
@yuxincs
yuxincs marked this pull request as ready for review July 29, 2026 15:18
@yuxincs
yuxincs enabled auto-merge (squash) July 29, 2026 15:18
@yuxincs
yuxincs force-pushed the yuxincs/remove-no-infer branch from 335cbe2 to 49cb1c4 Compare July 29, 2026 15:53
@yuxincs
yuxincs force-pushed the yuxincs/remove-no-infer branch from 49cb1c4 to 9026d15 Compare July 29, 2026 15:53
@yuxincs
yuxincs merged commit bb7d51b into main Jul 29, 2026
9 checks passed
@yuxincs
yuxincs deleted the yuxincs/remove-no-infer branch July 29, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants