Repository navigation
feat(pwa): feed country in admin (N7), country change clears feeds (N8), one feed per card - #122
Merged
Merged
Conversation
…y' into fix/n7-n8-duplicate-feed
…ed per card
N7 — Admin › Feeds: each card shows the feed's country, a country filter
narrows the list on screen, and the delete text names the country, since
feed names will be unique per country rather than library-wide.
N8 — Cattle Info → Continue with a different country while feed cards are
filled asks first ("Changing the country clears the n selected feeds"),
then clears every card. Cancel saves nothing. Same country (including
Kenya → India → Kenya), no filled cards, or a restored simulation: no
dialog. The feed cascade now matches a card by id when it has one.
Feed Selection: a feed may be on only one card. Picking it again from a
card's Feed list or from search shows "Already this feed is selected"
and changes nothing.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
satishbagali
enabled auto-merge
November 4, 2026 12:06
satishbagali
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three changes. The branch also contains #118 (N5), because the N8 request was written against
main+ #118. If #118 merges first, this PR's diff shrinks to the new work. If this merges first, #118 can be closed.N7: Admin › Feeds shows each feed's country
fd_country_name, under the type."X" (India) will be permanently deleted…. It falls back to the old text when a feed has no country.N8: changing the country clears the feed cards, after asking
role="dialog"andaria-modal, closes on Escape, and is covered by the global focus trap.cattle-info/useCountryChange.tsx, socattle-info/page.tsxstays under 600 lines.useFeedCascadematches a card byfeed_uuidwhen it has one, and by name only otherwise.One feed per card (Feed Selection)
4 new labels with all 9 languages. The translations are machine-made and need native review.
Tests
admin-feeds: the country on each card, the filter, and the country in the delete text.cattle-info: dialog → Continue clears and saves; Cancel keeps; same country / no feeds / restore → no dialog.FeedRowandfeed-selection: a duplicate is refused from the dropdown and from search; a new feed is accepted.feed-selection-rulesunit tests.7 of the new tests fail on the old code. The full gate passes on Node 20 after merging the latest
main(with #117): 979 tests.Check on Test
Please tell the backend owner once this and #118 are live: the "English feed name unique per country" change waits on them.
🤖 Generated with Claude Code