Conversation
…end date The cloud line and the banner images say "free credit to start, no card" and "prices can change while we learn, what you buy stays yours", so a price change during the soft launch never contradicts the repo.
…e credit to start, no amount and no end date The soft launch may change the prices and the free credit; what a customer buys stays theirs. No public line names the gift's size or a date any more, so a price change never contradicts the docs.
…otice, with the soft-launch words The cloud launch on main: the docs banner, the docs home, the daily notice, with the soft-launch words
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2338.
Summary
In BFS deep crawl,
link_discoverycomputed the remaining page budget per parent page without counting URLs already queued innext_levelby sibling parents. Each parent could queue the full remaining budget, so one level overshotmax_pages(14 left with 35 parents of 30 links each queued 490 URLs). The remaining capacity now subtractslen(next_level).List of files changed and why
How Has This Been Tested?
The new test fails before the change and passes after it.
Checklist:
Unticked: only the new test was run, not the full suite; no comments or docs changes were needed.