Skip to content

Update deployment documentation - #53

Merged
mihnita merged 2 commits into
unicode-org:mainfrom
mihnita:mihai_update_doc
Jun 8, 2026
Merged

mihnita merged 2 commits into
unicode-org:mainfrom
mihnita:mihai_update_doc

Conversation

@mihnita

@mihnita mihnita commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Still to do (in my opinion):

  • Update the build-and-push-to-gcr in upload-on-tag.yml to use the new
    "Google Unicode Dev - Community" project (goog-unicode-dev)
  • Separate the GCloud deployment doc in a common place, to cover both ICU4C and ICU4J demos
    Right now I updated icu4jweb/README.md in place because there was something already.
    But it was for ICU4J, and there was nothing for ICU4C, even that is virtually identical.
  • Update the README.md in the root. It is very very outdated.
    And does not even mention the building and deployment to GCloud, although at this point
    that is the whole reason for this repo to exist.

@mihnita
mihnita requested review from eggrobin, markusicu and srl295 June 6, 2026 00:43
eggrobin
eggrobin previously approved these changes Jun 6, 2026
Comment thread icu-kube/README.md Outdated
srl295
srl295 previously approved these changes Jun 7, 2026

@srl295 srl295 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Robin Leroy <egg.robin.leroy@gmail.com>
@mihnita
mihnita dismissed stale reviews from srl295 and eggrobin via 82d8b5c June 8, 2026 20:03
@mihnita
mihnita requested review from eggrobin and srl295 June 8, 2026 20:03
@mihnita

mihnita commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Thank you both!
I applied Robin's improvement and lost the approval.

@markusicu markusicu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

truly rslgtm
and thanks!!

@mihnita
mihnita merged commit 3862ba7 into unicode-org:main Jun 8, 2026
5 checks passed
@mihnita
mihnita deleted the mihai_update_doc branch June 9, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants