Move to edition 2024 - #20
Open
bmesuere wants to merge 1 commit into
Open
Conversation
The crate was still on the 2018 edition. `cargo fix --edition` through 2021 and then 2024 needed no source changes at all: the two migrations only touched the edition field. Edition 2024 needs Rust 1.85, comfortably under the 1.88 floor the locked dependency tree already imposes, so this costs nothing in reach. The source changes here are rustfmt's, not the migration's. The 2024 style edition sorts `clap::Args` before `clap::builder::...`, lays out the vec! in translate differently, and collapses a short if/else onto one line. All four CI jobs pass locally, including against the pinned 1.88 toolchain, and translate produces identical output with and without -m. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crate was still on the 2018 edition, which shipped in 2018.
cargo fix --editionthrough 2021 and then 2024 needed no source changes at all — both migrations only touched theeditionfield. That is the whole migration.Edition 2024 requires Rust 1.85, comfortably under the 1.88 floor the locked dependency tree already imposes (see #10), so this costs nothing in reach.
The diff is rustfmt, not the migration
The source changes here come from the 2024 style edition, not from the language edition:
clap::Argsbeforeclap::builder::...)vec!intranslatelays out differentlyif start && methionine { ... } else { ... }collapses onto one lineNothing semantic. I checked the
translatemethionine branch specifically since the formatter touched it: identical output with and without-m, across-f 1and-a.Verification
All four CI gates pass locally, including
cargo clippy -- -D warningsand the pinned 1.88 build. 39 tests pass, and the full pipeline runs end to end through FragGeneScanRs to tryptic peptides.