Repository navigation
Fix broken GPG keyservers in all Dockerfiles - #39
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the GPG keyserver endpoints used during image builds across all versioned Dockerfiles, replacing defunct SKS/legacy keyservers so that key import and subsequent signature verification can succeed again (unblocking CI build/publish for tags like 0.21).
Changes:
- Replaced
pgp.mit.edu,keyserver.pgp.com, andsks-keyservers.netpool usage withhkps://keys.openpgp.org. - Added
hkps://keyserver.ubuntu.comas a fallback keyserver in each Dockerfile’s key import loop.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| 0.21/Dockerfile | Switches GPG key retrieval to modern HKPS keyservers for the 0.21 image build. |
| 0.18/Dockerfile | Updates keyserver endpoints for reliable key import during 0.18 image build. |
| 0.17/Dockerfile | Updates keyserver endpoints for reliable key import during 0.17 image build. |
| 0.16/Dockerfile | Updates keyserver endpoints for reliable key import during 0.16 image build. |
| 0.15/Dockerfile | Updates keyserver endpoints for reliable key import during 0.15 image build. |
| 0.14/Dockerfile | Updates keyserver endpoints for reliable key import during 0.14 image build. |
| 0.13/Dockerfile | Updates keyserver endpoints for reliable key import during 0.13 image build. |
| 0.10/Dockerfile | Updates keyserver endpoints for reliable key import during 0.10 image build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pedrobranco
previously approved these changes
Aug 6, 2026
pgp.mit.edu, keyserver.pgp.com and the sks-keyservers.net pool are unreachable, so key import fails and every build (0.10 through 0.21) dies at that step. This blocked publishing the 0.21.5.6 security bump from #38 -- `build (0.21)` failed 5 consecutive attempts on master and uphold/litecoin-core:0.21 still serves the image built in Feb 2024. Switch to keys.openpgp.org with keyserver.ubuntu.com as fallback. Also pin both Litecoin signing keys by full 40-hex fingerprint instead of 64-bit long key ID, matching what docker-dash-core already does and what the gosu key here already used. Fetching by long ID leaves the import open to key-ID collision; with a full fingerprint gpg rejects any key that does not match. 3620E9D387E55666 -> D35621D53A1CC6A3456758D03620E9D387E55666 David Burkett <davidburkett38@gmail.com> FE3348877809386C -> 59CAF0E96F23F53747945FD4FE3348877809386C Adrian Gallagher <thrasher@addictionsoftware.com>
joaomatbarbosa
force-pushed
the
support/fix-broken-gpg-keyservers
branch
from
August 6, 2026 09:44
b60e371 to
ec74b2a
Compare
pedrobranco
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.21push after Bump litecoin-core 0.21.5.6 #38 merged failed, so the 0.21.5.6 security fix was never actually published to Docker Hub.Test plan
0.21image locally with the updated Dockerfile — GPG import and verification succeed, litecoin 0.21.5.6 downloads and verifies correctly.