Skip to content

Near axis refactor#34

Merged
EstevaoMGomes merged 4 commits into
eg/analysisfrom
near-axis-refactor
Jul 11, 2026
Merged

Near axis refactor#34
EstevaoMGomes merged 4 commits into
eg/analysisfrom
near-axis-refactor

Conversation

@Agastyarathee

Copy link
Copy Markdown

Summary

This PR extracts the near_axis class (approx. 600 lines) from essos/fields.py into a new, standalone repository: pyQSC_JAX.

Changes Made

  • Refactored fields.py: Removed the near_axis class and replaced it with a detailed ImportError that guides users to the new package.
  • Updated Imports: Modified tests/ and examples/ files (e.g., test_near_axis.py, stella_stability.py) to import from the external pyqsc_jax package.
  • Preserved Core Functions: Ensured BiotSavart and BiotSavart_from_gamma remain safely intact within the native ESSOS environment.

Testing

  • Verified standalone installation of pyQSC_JAX via pip.
  • Checked local examples to ensure JAX compilation and plot generation still function correctly with the split architecture.

@rogeriojorge rogeriojorge left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agastyarathee, please make a pull request into the eg/analysis branch (instead of into the main branch) so that we can review your changes only.

@Agastyarathee
Agastyarathee changed the base branch from main to eg/analysis June 10, 2026 18:02

@rogeriojorge rogeriojorge left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, if the near-axis examples work, then it's good to merge.

@EstevaoMGomes EstevaoMGomes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to be merged.

@EstevaoMGomes

Copy link
Copy Markdown
Collaborator

Rebased near axis refactor to eg/analysis.

@EstevaoMGomes
EstevaoMGomes merged commit 448356f into eg/analysis Jul 11, 2026
@EstevaoMGomes
EstevaoMGomes deleted the near-axis-refactor branch July 11, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants