Add FullOrbitAdaptative model and correct SIMSOPT tracing comparison#45
Merged
EstevaoMGomes merged 1 commit intoJul 17, 2026
Merged
Conversation
EstevaoMGomes
self-requested a review
July 17, 2026 13:51
EstevaoMGomes
approved these changes
Jul 17, 2026
EstevaoMGomes
left a comment
EstevaoMGomes
left a comment
Collaborator
There was a problem hiding this comment.
Simple PR that I think is ready to be merged
…ive and correct simsopt tracing comparison (adaptive models, Dopri5, matched output points). Verified: 12 examples FAIL->PASS, zero regressions.
Tejas7007
force-pushed
the
fix/simsopt-comparison
branch
from
July 17, 2026 14:17
e142c34 to
c2a0280
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an adaptive full-orbit model and fixes the SIMSOPT comparison scripts so the tracing benchmark is like-for-like.
FullOrbitAdaptative : full orbit was fixed-step only (Boris needs constant Δt). This adds an adaptive option so the comparison can use matched step control and Boris path is unchanged.
Comparison scripts : the plain GuidingCenter/FullOrbit/FieldLine models ignored atol/rtol (no stepsize controller → ConstantStepSize), and the default solver was Dopri8 while scripts labelled it Dopri5. Scripts now use the Adaptative models with solver=diffrax.Dopri5() on both sides, matched output points, and working atol/rtol/num_steps.
Rebased on eg/analysis (post-#42). Verified the scripts run on the merged base.
ESSOS is faster where only B is evaluated (full orbit, field lines) and slower for guiding centre where ∇|B| is autodiffed, as expected given the analytical-vs-autodiff gradient difference the paper already documents.