Make solver step limit configurable#16
Open
rogeriojorge wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
rogeriojorge
marked this pull request as ready for review
July 13, 2026 03:57
Member
Author
|
Additional production-duration GPU evidence (2026-07-12):
This six-minute run reinforces the earlier controlled H8 result: setting |
rogeriojorge
force-pushed
the
agent/expose-solver-result
branch
from
July 13, 2026 05:17
d4870d9 to
aa02e2f
Compare
rogeriojorge
force-pushed
the
agent/configure-max-steps
branch
from
July 13, 2026 05:17
1f68a8d to
ae77266
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_stepsthroughsimulationRESULTS.max_steps_reachedThis is stacked on #14 so callers using
throw=Falsecan inspect the failure result. Diffrax usesmax_stepsfor the bounded solver loop and checkpointing machinery, so production fixed-step runs should set it close toceil(t_max / dt)with a small safety margin.Validation
pytest -q(4 passed)max_steps=11is bitwise identical to the existing 1,000,000-step boundRESULTS.max_steps_reachedTwo-A4000 benchmark
Orszag-Tang, 129x129 Fourier, 8x8x8 Hermite, Tsit5, 100 fixed steps:
max_steps=1_000_000: 23.996 smax_steps=101: 13.941 smax_steps=101: 30.776 sBoth bounds conserve total energy to machine precision. Compilation remains approximately 1.9 s.