Configure midpoint Krylov limits#22
Open
rogeriojorge wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
84ccf22 to
5de0421
Compare
40c9082 to
134f3c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linear_restartandlinear_max_restartsonImplicitMidpointDefaults remain
20, preserving the current solver behavior. This is stacked on #21.Why
FGMRES allocates a shape-static Krylov basis, so restart controls compilation size and accelerator memory even when a solve converges early. Large plasma states that converge in one or two inner iterations should be able to select a smaller basis without reducing the nonlinear Newton iteration limit.
Validation
pytest -q(5 passed)65x65 x 6x6x6, five midpoint steps: 1.079 s at20/20versus 0.832 s at2/2Ck,Fk, and total energy were bitwise identicalThe measured 23% runtime improvement is configuration-specific; the PR changes no default.