Precondition midpoint Hermite streaming lines#31
Open
rogeriojorge wants to merge 1 commit into
Open
Conversation
rogeriojorge
marked this pull request as ready for review
July 13, 2026 15:00
rogeriojorge
force-pushed
the
agent/midpoint-custom-inner-product
branch
from
July 16, 2026 14:13
8cf6fd0 to
e42f3b8
Compare
rogeriojorge
force-pushed
the
agent/midpoint-streaming-preconditioner
branch
from
July 16, 2026 14:13
e14eebf to
4503cb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation and evidence
The existing diagonal preconditioner removes collision/diffusion stiffness but not the tridiagonal free-streaming coupling in Hermite space. This change solves that physics block exactly along each local x-Hermite line.
On the four-device 513-Fourier by 256-Hermite Landau run to t=5, it reduced trajectory time from 196.015 s to 21.521 s and GMRES work from 46,015 (maximum 119 per step) to 3,144 (maximum 9). Relative energy change remained 3.83e-13; endpoint coefficient difference was 1.06e-12 relative and the final/initial field-norm ratio changed from 0.4358742732 to 0.4358742563.
On 257 by 128 Landau to t=1, runtime fell from 8.131 s to 3.462 s and GMRES work from 1,960 to 231.
This is deliberately not a replacement for the diagonal preconditioner. On 2-D 65-squared Orszag--Tang, iteration counts were unchanged and line-factorization overhead increased runtime from 5.776 s to 6.849 s. A two-stream control also confirms that callers must retain accuracy-appropriate linear tolerances; no tolerance is changed here.
Verification
Scope
This PR intentionally does not cache factors across time steps, add y/z alternating-direction solves, change midpoint defaults, or modify SOLVAX. Those extensions should be benchmarked independently.