Skip to content

Fix periodic Orszag-Tang grid#8

Open
rogeriojorge wants to merge 2 commits into
mainfrom
agent/fix-periodic-orszag-tang-grid
Open

Fix periodic Orszag-Tang grid#8
rogeriojorge wants to merge 2 commits into
mainfrom
agent/fix-periodic-orszag-tang-grid

Conversation

@rogeriojorge

@rogeriojorge rogeriojorge commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary

  • use jnp.linspace(..., endpoint=False) for the three periodic Orszag-Tang coordinates
  • keep the fix local to the example; no new helper API or tests

Root cause

The example included both endpoints of each periodic interval. The Fourier solver expects N distinct nodes with spacing L / N, so duplicating the endpoint injected unintended Fourier content into the initial condition.

Impact

The Orszag-Tang initialization now matches SPECTRAX's discrete periodic Fourier grid with a three-line change.

Validation

  • pytest -q - 3 passed
  • git diff --check - passed
  • isolated Fourier-mode leakage on a 33-point grid: 1.42e-16

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rogeriojorge
rogeriojorge marked this pull request as ready for review July 13, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant