Fix periodic Orszag-Tang grid#8
Open
rogeriojorge wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
rogeriojorge
marked this pull request as ready for review
July 13, 2026 02:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jnp.linspace(..., endpoint=False)for the three periodic Orszag-Tang coordinatesRoot cause
The example included both endpoints of each periodic interval. The Fourier solver expects
Ndistinct nodes with spacingL / N, so duplicating the endpoint injected unintended Fourier content into the initial condition.Impact
The Orszag-Tang initialization now matches SPECTRAX's discrete periodic Fourier grid with a three-line change.
Validation
pytest -q- 3 passedgit diff --check- passed1.42e-16