Fix odd-grid RFFT energy weights#9
Open
rogeriojorge wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
b3454d7 to
c3a6598
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nxis evenNx=1caseRoot cause
The electromagnetic-energy diagnostic always assigned weight one to the final RFFT coefficient. That is correct for an even grid, where the final coefficient is the Nyquist singleton. For odd
Nx, the final retained coefficient still has an omitted negative-frequency conjugate and must have weight two.Impact
Electromagnetic and total-energy diagnostics now satisfy Parseval weighting for both odd and even Fourier resolutions. This is especially relevant because the supplied SPECTRAX examples commonly use odd
Nxvalues.Validation
python3 -m pytest -q— 6 passedpython3 -m flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics— 0Nx = 1, 4, 5, 32, 33— agreement to7e-16or better