Repository navigation
Root CA fallback to system bundle (bsc#1262720) - #84
Merged
Merged
Conversation
If an error happens when listing the peripheral IDs, we won't get the root CAs. With some luck they can be the same than the hub root CA that is mounted in the container. In this case, using the system bundle and adding the fetch root CAs would prevent obscure errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a new certificate bundle completely ignores the system trusted CAs. This may be fine if there is no error when getting the peripheral systems IDs… This PR uses the system CAs and adds the ones we got to it. This doesn't alter the system bundle, but at least we have a chance to be able to continue if anything wrong happened (like null Root CA throwing an exception).
To also help debugging what happens on the client side, I added a
HUB_TRACE_CLIENTenv variable.