feat(ai): add new 'InvalidToolCall' part#14337
Draft
aayush-kapoor wants to merge 3 commits intomainfrom
Draft
Conversation
tigent
bot
added
ai/core
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| // insert error tool outputs for invalid tool calls: | ||
| // TODO AI SDK 6: invalid inputs should not require output parts | ||
| const invalidToolCalls = stepToolCalls.filter( | ||
| toolCall => toolCall.invalid && toolCall.dynamic, |
Contributor
There was a problem hiding this comment.
Multi-step tool call loop terminates prematurely when invalid tool calls are present because clientToolCalls includes them but clientToolOutputs doesn't, causing the count comparison clientToolOutputs.length === clientToolCalls.length to be false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
there was a TODO comment talking about cleaning up the way we pass invalid tool calls (when incorrect json args are returned by the model)
previously, invalid tool calls were emitted as dynamic tool calls (even if the tool wasn't dynamic) and then a dummy
tool-erroroutput was passed in place of invalid tool calls so the model would get a matching tool result in the next step.Summary
InvalidToolCallto-response-messages.tsdetectsInvalidToolCallcontent parts and auto-generates error tool-results for the model, so generateText and streamText don't need to manufacture fake outputsInvalidToolUIPartis its own UI part type with type: 'invalid-tool' and state: 'error', so the UI can render invalid tool calls distinctly from real execution errors or dynamic tools.Manual Verification
will create an example
Checklist
pnpm changesetin the project root)