Skip to content

Fix data loss bug when calling setLocalKey with the same name#19

Merged
insign merged 1 commit intomainfrom
fix-set-local-key-data-loss-5993508592573781986
May 8, 2026
Merged

Fix data loss bug when calling setLocalKey with the same name#19
insign merged 1 commit intomainfrom
fix-set-local-key-data-loss-5993508592573781986

Conversation

@insign
Copy link
Copy Markdown
Contributor

@insign insign commented May 1, 2026

Este PR corrige um bug crítico de perda de dados no método setLocalKey, garantindo maior confiabilidade ao pacote.

Anteriormente, chamar setLocalKey passando uma string igual à chave atual ($currentKey) causava a exclusão não intencional dos dados de progresso no array geral (devido ao uso do unset()), reiniciando o estado incorretamente para zero. A correção introduz um retorno antecipado quando a chave fornecida é idêntica à atual, preservando os dados corretamente.

Arquivos alterados:

  • src/Progressable.php: Adicionado o early return em setLocalKey.
  • tests/ProgressableTest.php: Adicionado o teste test_set_local_key_with_same_name_preserves_data para assegurar que a correção mantenha o comportamento em futuras iterações.

Nenhum arquivo .md necessitou atualização pois não há alterações de uso na API do pacote, mantendo a consistência do documento atual.


PR created automatically by Jules for task 5993508592573781986 started by @insign

* Fix data loss bug in setLocalKey method by returning early if new key matches the current key.
* Add test case to ensure data is preserved when using the same key name.

Co-authored-by: insign <1113045+insign@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@insign insign merged commit 67fee16 into main May 8, 2026
4 checks passed
@insign insign deleted the fix-set-local-key-data-loss-5993508592573781986 branch May 8, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant