Conversation
* Fix data loss bug in setLocalKey method by returning early if new key matches the current key. * Add test case to ensure data is preserved when using the same key name. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Este PR corrige um bug crítico de perda de dados no método
setLocalKey, garantindo maior confiabilidade ao pacote.Anteriormente, chamar
setLocalKeypassando uma string igual à chave atual ($currentKey) causava a exclusão não intencional dos dados de progresso no array geral (devido ao uso dounset()), reiniciando o estado incorretamente para zero. A correção introduz um retorno antecipado quando a chave fornecida é idêntica à atual, preservando os dados corretamente.Arquivos alterados:
src/Progressable.php: Adicionado o early return emsetLocalKey.tests/ProgressableTest.php: Adicionado o testetest_set_local_key_with_same_name_preserves_datapara assegurar que a correção mantenha o comportamento em futuras iterações.Nenhum arquivo
.mdnecessitou atualização pois não há alterações de uso na API do pacote, mantendo a consistência do documento atual.PR created automatically by Jules for task 5993508592573781986 started by @insign