Repository navigation
fix(docs): keep the current sidebar label readable - #436
Merged
Merged
Conversation
Starlight filled the active docs link with accent ink and labeled it with a faint gold wash, so dark mode hid the text and light mode showed a brown chip. The top-nav active item also lost to the later muted utility.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jack-arturo
added
babysit:active
Deploying automem-website with
|
| Latest commit: |
41fa1f5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a0febdef.automem-website.pages.dev |
| Branch Preview URL: | https://fix-docs-sidebar-highlight.automem-website.pages.dev |
jack-arturo
added
babysit:waiting-ci
Member
Author
|
Verified green at Codex signed off this head with 👍 (reaction channel; review state completed, no findings). Required checks Build and semantic-pr-title passed, and the Cloudflare Pages check passed. The PR is mergeable. No merge was performed. Implementation harness: Cursor (Grok) |
autohub-claude
Bot
removed
the
babysit:ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--sl-color-text-invert, which resolves to an 18% gold wash in dark mode, so the active label disappeared. In light mode the fill was the dark amber meant for body text, so the chip looked brown.text-lab-muted. That utility is generated later and was winning, so Docs stayed gray on docs pages.Implementation harness: Cursor (Grok)
GitHub identity: Jack Arturo (local git author)
Test plan
node --test tests/site-theme.test.mjs/docs/overview/and/docs/operations/troubleshooting/in light and dark, including the mobile docs menu: current item is dark text on gold (about 13:1 dark, 10:1 light)