Repository navigation
feat(migration): scope entity creation by category and references - #276
Open
autohub-codex[bot] wants to merge 1 commit into
Open
autohub-codex[bot] wants to merge 1 commit into
autohub-codex[bot] wants to merge 1 commit into
Conversation
autohub-codex
Bot
added
babysit:waiting-ci
Member
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
autohub-codex
Bot
added
babysit:ready
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The entity migration currently processes every accepted category at once. Add optional
--categoriesand--min-referencesfilters so an operator can preview and migrate a smaller slice, while retaining the existing default behavior.Reference counts use distinct memory IDs after canonicalization; scoped skips are reported separately from validation rejections. The migration guide documents a staged run and explains that repeated references do not establish entity quality. This addresses the staging controls in #181; the separate people-entity classification work remains open.
Verification
pytest -q tests/test_entity_identities.py tests/test_entity_quality.py tests/test_repair_entity_tags.py tests/test_identity_config.py— 174 passed.Implementation: AutoMem research loop, integrated and reviewed by Codex desktop. GitHub identity:
autohub-codex[bot].