Skip to content
This repository was archived by the owner on Oct 21, 2026. It is now read-only.
This repository was archived by the owner on Oct 21, 2026. It is now read-only.

Chore: Run the Minimal Pre-Release Agent-Ready Smoke Test #2931

Closed

Description

@mihar-22

Context

A short pre-release check should catch broken commands, registries, Markdown, or skill behavior before the coordinated pull-request stacks merge.

Outcome

Run the exact primary prompts in clean Next.js, plain HTML, and Vite applications and resolve or file any release-blocking failure.

References

Activity

  1. added this to the GA milestone on Sep 22, 2026
  2. self-assigned this
    on Sep 22, 2026
  3. changed the title [-]Run the Minimal Pre-Release Agent-Ready Smoke Test[/-] [+]Chore: Run the Minimal Pre-Release Agent-Ready Smoke Test[/+] on Sep 22, 2026
  4. github-actions commented on Sep 22, 2026

    @github-actions
    Contributor

    The exact primary prompts and expected success criteria are not included here, so please add them (or paste a versioned test matrix) for the Next.js, plain-HTML, and Vue runs. That will make this a repeatable release gate rather than an ad-hoc check.

    Planning: this is a GA release-gate task and should remain under videojs/video.js#9440; P1 is appropriate because a failed smoke should block the coordinated launch stack. Coordinate its execution with the release-ready states of #2848, #2883, and videojs/skills#1. No duplicate identified.

  5. mihar-22 commented on Sep 25, 2026

    @mihar-22
    MemberAuthor

    Smoke test results: pass, no release blockers

    I ran each installation guide's AI Quickstart prompt in clean apps with two real coding agents, headless, each in an isolated config.

    App Guide prompt Claude Code Codex
    Next.js (create-next-app) React ✅ ✅
    Plain HTML page (no package.json) HTML ✅ plays, but see finding 1 ✅ plays, but see finding 1
    Vite (vanilla TS) HTML ✅ ✅
    Vite + Vue Vue ✅ ✅

    How it ran

    • Session 1: the guide's exact AI Quickstart prompt.
    • Session 2: a fresh session in the same config, asked to "Add a Video.js video player to this app's main page that plays a demo video", mirroring the skill's own "start a new session" follow-up.
    • Pre-release sources: the CLI from pkg.pr.new/@videojs/cli@c40afc2 (main), @videojs/* packages from the same preview, the skill from the feat/videojs-skill branch of feat: add videojs agent skill skills#1, and docs from main.videojs.org. The CDN path used the published 10.0.0-rc.2 CDN, because jsDelivr only serves released versions.
    • Verification: I rebuilt every app (npm run build passes in all 8) and loaded the production builds in a browser. Every player loads the demo video and plays (readyState 4, currentTime advancing) with no errors.

    What worked in every run

    • Each agent ran agents skills, installed the skill with its own client, and said a new session was needed.
    • In session 2 the skill was loaded. For Codex, its session lists videojs:videojs.
    • Agents planned with agents init using explicit flags, and installed the version the plan named.

    Findings (non-blocking follow-ups)

    1. Plain HTML page becomes an npm project. Asked to add a player to a static page, both agents scaffolded Vite into it (package.json, src/) instead of using CDN scripts. Codex used CDN first, then switched when asked again.
      • Cause: agents init defaults to --method packaged. It detects "an index.html with no package.json", but the packaged plan for an existing page needs a bundler, so agents create a new app instead.
      • Suggested fix: when the CLI detects a plain page, default to --method cdn and list it as defaulted with its source.
    2. Codex treats the Quickstart prompt as a build request. "Then use the Video.js skill for this project" led Codex to add a player in session 1, before anyone asked for one. Claude Code only installed the skill.
      • Suggested wording: "…when you work on video or audio in this project."

    Not covered

    The exact released commands (npx @videojs/cli, videojs/skills) can't be exercised until the release is out and videojs/skills#1 merges. A short repeat after release would cover them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions