feat: removed e2e default [pre-release] - #392
Merged
Merged
Conversation
junydania
changed the title
xavidop
approved these changes
Jun 23, 2026
There was a problem hiding this comment.
Pull request overview
Adjusts the vfcli-create-or-get-free-env-from-pool command’s node-group parameter so e2e (and other non-dev) environment provisioning can rely on vfcli’s default capacity-type scheduling rather than implicitly pinning to the e2e node group.
Changes:
- Removes the
node-groupparameter default of"e2e"and replaces it with an empty default. - Expands the
node-groupparameter description to document intended scheduling behavior when left empty.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+17
to
+20
| description: | | ||
| Name of the node group to pin the environment to. Leave empty (default) to use | ||
| vfcli's capacity-type scheduling: non-dev envs (test-/review-/e2e-) default to spot. | ||
| default: "" |
Contributor
|
Your orb has been published to the CircleCI Orb Registry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes or implements IN-4087
Brief description. What is this change?
Stop e2e envs from using default nodegroup flag of e2e
Implementation details. How do you make this change?
Setup information
Deployment Notes
Related PRs
Checklist