fix(ipc): fill the buffer on partial reads in the sync message reader - #10284
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
`SyncMessageReader` issued a single `read` into the resized buffer and handed it straight to the decoder. On a short read — legal for any `Read`, common over pipes and sockets — the buffer kept its zero padding, which the decoder treats as real data (it checks `remaining()`, not bytes written) and decodes as garbage. Loop until the buffer is filled before decoding, and report a truncated stream as an error instead of returning garbage, mirroring the async reader. Signed-off-by: jackylee-ch <qcsd2011@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SyncMessageReaderdid a singlereadinto the resized buffer and handed it tothe decoder. On a short read — legal for any
Read, common over pipes andsockets — the buffer kept its zero padding, which the decoder treats as real data
(it checks
remaining(), not bytes written) and decodes as garbage.Fix
Loop until the buffer is filled before decoding, and report a truncated stream as
an error instead of returning garbage. This mirrors the partial-read handling the
async
AsyncMessageReaderalready has.AI assistance
Prepared with AI assistance; I have reviewed and verified the change.