Skip to content

Audit tests for duplication and coverage - #10458

Open
robert3005 wants to merge 1 commit into
developfrom
rk/removeredundanttests
Open

robert3005 wants to merge 1 commit into
developfrom
rk/removeredundanttests

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Some of the tests covered duplicate logic, they haven't been updated to latest helper functions or simply didn't check the correct thing. This should have audited all of the tests we have in the repo and fix them without losing coverage

@robert3005 robert3005 added the changelog/chore A trivial change label Oct 12, 2026
@robert3005
robert3005 force-pushed the rk/removeredundanttests branch from 70a4472 to 25ba6a5 Compare October 12, 2026 21:22
@codspeed

codspeed Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 1.12%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 1 benchmark measured no execution time

Nothing ran under measurement, usually because the compiler removed the code under test. This result is not comparable, so it counts as unchanged.

Preventing compiler optimizations

⚠️ 10 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

⚡ 4 improved benchmarks
❌ 3 regressed benchmarks
✅ 2206 untouched benchmarks
🗄️ 43 archived benchmarks run1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation decode_primitives[i64, (1000, 32)] 25.4 µs 37.1 µs -31.52%
❌ WallTime starts_with_avx2[8, VarBin] 41 µs 47 µs -12.72%
❌ WallTime bitpack_blocked_compress_avx2 6.8 µs 7.6 µs -10.28%
⚡ WallTime filter_avx2[64] 2.5 µs 2.1 µs +16.46%
⚡ WallTime filter_avx2[8] 1.2 µs 1 µs +16.24%
⚡ WallTime filter_avx2[80] 2.6 µs 2.3 µs +13.89%
⚡ WallTime compare_u8_neon 2 µs 1.8 µs +11.8%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/removeredundanttests (a95bf52) with develop (2664573)

Open in CodSpeed

Footnotes

  1. 43 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩

robert3005 added a commit that referenced this pull request Oct 13, 2026
fix the assertions that have been found by test audit

extracted from #10458

---------

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 force-pushed the rk/removeredundanttests branch from 25ba6a5 to a95bf52 Compare October 13, 2026 14:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant