Skip to content

Make Null take an execute kernel - #10585

Merged
robert3005 merged 1 commit into
developfrom
rk/legacy-session-null-take
Oct 19, 2026
Merged

robert3005 merged 1 commit into
developfrom
rk/legacy-session-null-take

Conversation

@robert3005

@robert3005 robert3005 commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Null take executed its indices to bounds-check them inside a TakeReduce rule. A reduce rule has no execution context, so it used legacy_session(). It now implements TakeExecute, which the new null::initialize registers on the session, and the reduce rule is removed.

part of #9446

Null take executed its indices inside a reduce rule, which has no execution
context, by reaching for the hidden global `legacy_session()`. Implement
`TakeExecute` instead and register it on the session.

Signed-off-by: Claude <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y1zHpE1K1Y9HvyU4kt24Tq
@codspeed

codspeed Bot commented Oct 18, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 12.66%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 18 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 40 benchmarks have no flame graph

The flamegraph could not be generated because we failed to resolve the symbols in the profiling trace. This happens when we fail to harvest information about language frames.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 4 regressed benchmarks
✅ 2403 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ ⚠️ Simulation random_i128[0.01] 3.8 µs 5.6 µs -31.81%
❌ Simulation sum_v2_i64 194.2 µs 224.8 µs -13.62%
❌ Simulation sum_i64 194.7 µs 225 µs -13.49%
❌ WallTime bitpack_blocked_compress_avx2 6.7 µs 7.7 µs -12.34%
⚡ WallTime starts_with_avx2[8, VarBin] 46.6 µs 41 µs +13.74%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/legacy-session-null-take (5128755) with develop (5fc5cb8)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005 robert3005 added the changelog/chore A trivial change label Oct 19, 2026
@robert3005
robert3005 marked this pull request as ready for review October 19, 2026 10:26
@robert3005
robert3005 enabled auto-merge (squash) October 19, 2026 10:38
@robert3005
robert3005 merged commit f5f222a into develop Oct 19, 2026
123 of 126 checks passed
@robert3005
robert3005 deleted the rk/legacy-session-null-take branch October 19, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants