Skip to content

duplicate ZstdBuffer's validity into a slot instead of using the legacy session - #10586

Merged
robert3005 merged 2 commits into
developfrom
rk/legacy-session-zstd-buffers
Oct 19, 2026
Merged

robert3005 merged 2 commits into
developfrom
rk/legacy-session-zstd-buffers

Conversation

@robert3005

@robert3005 robert3005 commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

ValidityVTable::validity has no context, and ZstdBuffers used to rebuild its wrapped array (which needs a session) to answer it. Now the validity is lifted out of the wrapped array when compressing, so it can be read straight from a slot without decompressing anything and without storing a session.

part of #9446

`ValidityVTable::validity` has no context, but a ZstdBuffers array has to
rebuild its inner array to answer it. Keep the session the array was
compressed or deserialized with instead of using the hidden global
`legacy_session()`.

Signed-off-by: Claude <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y1zHpE1K1Y9HvyU4kt24Tq
@codspeed

codspeed Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 21.8%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ 19 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 40 benchmarks have no flame graph

The flamegraph could not be generated because we failed to resolve the symbols in the profiling trace. This happens when we fail to harvest information about language frames.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 8 regressed benchmarks
✅ 2399 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ WallTime threshold_neon[8] 1.4 µs 2.8 µs -51.71%
❌ WallTime threshold_neon[64] 2.5 µs 3.7 µs -33.14%
❌ WallTime filter_neon[8] 886 ns 1,194 ns -25.8%
❌ WallTime threshold_neon[80] 3.4 µs 4.4 µs -22.07%
❌ WallTime filter_neon[80] 2.5 µs 3.2 µs -21.23%
❌ WallTime filter_neon[64] 1.8 µs 2.1 µs -15.63%
❌ WallTime bitpack_blocked_compress_avx2 6.7 µs 7.6 µs -12.17%
❌ WallTime decode_chunked_neon[i64, 524288] 13.3 µs 14.8 µs -10.66%
⚡ WallTime starts_with_avx2[8, VarBin] 46.6 µs 41.5 µs +12.38%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/legacy-session-zstd-buffers (e70be20) with develop (5fc5cb8)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ZstdBuffers stores the wrapped array's validity as a slot when compressing,
reusing the wrapped array's own validity child when it has one. Validity is
then read without decompressing or rebuilding the wrapped array, so the array
no longer needs a session. Arrays serialized before this change compute their
validity once at deserialize time.

Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y1zHpE1K1Y9HvyU4kt24Tq
@robert3005 robert3005 changed the title Keep the session in ZstdBuffers for validity Lift ZstdBuffers validity into a slot instead of using the legacy session Oct 18, 2026
@robert3005 robert3005 added the changelog/break A breaking API change label Oct 19, 2026
@robert3005
robert3005 marked this pull request as ready for review October 19, 2026 09:23
@robert3005
robert3005 enabled auto-merge (squash) October 19, 2026 09:23
@joseph-isaacs joseph-isaacs changed the title Lift ZstdBuffers validity into a slot instead of using the legacy session duplicate ZstdBuffer's validity into a slot instead of using the legacy session Oct 19, 2026
@robert3005
robert3005 merged commit 43e7294 into develop Oct 19, 2026
127 of 132 checks passed
@robert3005
robert3005 deleted the rk/legacy-session-zstd-buffers branch October 19, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants