Delta validity is a top level child - #9970
robert3005 wants to merge 2 commits into
Conversation
f1e55d9 to
ef96e92
Compare
Merging this PR will improve performance by 10.47%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | words_gather_dispatch_neon[65536] |
2.3 µs | 2 µs | +10.47% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fix/fastlanes-delta-validity-top-child (81b248c) with develop (4435d5b)2
Footnotes
-
518 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(76381d5) during the generation of this report, so 4435d5b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
ef96e92 to
2d0a705
Compare
2d0a705 to
46cb5dc
Compare
For performant delta encoding we have to read all the values in deltas buffer that means that undefined values in deltas buffer are significant. Instead of performing careful transformation dance to ensure correctness we remove null values from deltas and keep them as a top level child. Cascading encodings don't need any special handling and will preserve all values since they're all valid. Signed-off-by: Robert Kruszewski <github@robertk.io>
46cb5dc to
75b7296
Compare
For performant delta encoding we have to read all the values in deltas
buffer that means that undefined values in deltas buffer are
significant. Instead of performing careful transformation dance to
ensure correctness we remove null values from deltas and keep them as
a top level child. Cascading encodings don't need any special handling
and will preserve all values since they're all valid.