Remove redundant finite check for credit values#470
Merged
Conversation
The AttributionConversionOptions.credit field is defined as a sequence<double>, which is already guaranteed to be finite per WebIDL. The equivalent check is already properly represented as an assertion in the simulator. https://webidl.spec.whatwg.org/#idl-double
apasel422
marked this pull request as ready for review
July 16, 2026 14:32
csharrison
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AttributionConversionOptions.creditfield is defined as asequence<double>, which is already guaranteed to be finite per WebIDL.The equivalent check is already properly represented as an assertion in the simulator.
https://webidl.spec.whatwg.org/#idl-double
Preview | Diff