feat(apis): route wow and overwatch endpoints and add blizzard credentials - #5778
Merged
Merged
Conversation
…tials Expose /wow and /overwatch on api.ok8.sh, rewritten to the new /api/wow and /api/overwatch endpoints in apis, configure the tracked character and BattleTag, and pull the Blizzard client credentials from the blizzard 1Password item. Signed-off-by: Jordan Jones <git@svcs.ok8.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires up the new game profile endpoints from kashalls/apis#17:
api.ok8.sh/wow/*→/api/wow/*andapi.ok8.sh/overwatch/*→/api/overwatch/*.WOW_CHARACTERS: retail/area-52/Nyãna,OVERWATCH_BATTLETAGS: Kashall#11253.apis-secretnow also extracts theblizzard1Password item intoBLIZZARD_CLIENT_ID/BLIZZARD_CLIENT_SECRET.Before merging
ghcr.io/kashalls/apis:rollinghas rebuilt. Until then the new routes 404 and the env vars are ignored, so merging early is harmless.blizzard1Password item has fields named exactlyBLIZZARD_CLIENT_IDandBLIZZARD_CLIENT_SECRET. A missing key fails templating for the wholeapis-secret, which would also stall the Spotify/GitHub/Home Assistant values.Verify after rollout
An empty list means the lookup failed; the reason is logged (
fetch wow character/fetch overwatch player). Overwatch stays empty until the Kashall#11253 career profile is set to public in-game.