Skip to content

feat(移除重复代码): this.events[name].push(callback) 这行代码可以移除的 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yaolinhong wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(移除重复代码): this.events[name].push(callback) 这行代码可以移除的 #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/core/src/components/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ export default class TinyPlayEvents {
const type = this.type(name)
if (type && typeof callback !== 'function') return console.error(`${name} 事件的回调函数必须是一个函数`)
if (!this.events[name]) this.events[name] = []
this.events[name].push(callback)
// 重复代码 移除
// this.events[name].push(callback)
// video 事件，直接绑定到 video 元素上
if (type === 'video') {
this.player.video.addEventListener(name, callback)
Expand Down