Feature/add postgresql support#754
Open
bap14 wants to merge 4 commits into
Open
Conversation
Member
Author
|
The default is still mysql / mariadb. It adds a new The current drawback is that only one database is allowed at a time, so you can't run both mysql and postgres. That's a feature that could be done in the future, but at the moment the key was to get it functioning. |
Member
|
Thanks for your hard work here, @bap14! Looks like I have a lot to review tomorrow. I will likely change or request changed the name to match a wip PR I have to align env variables with Den. But I'm excited to take a deeper look at this tomorrow |
|
any update on this ?! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding the PostgreSQL images, this adds support to warden environments (or should). This emits a warning that using partials like
db.base.ymlordb.darwin.ymlare deprecated and should be replaced withdb.mysql.base.ymlordb.mysql.darwin.yml.I tested the DB connection and DB dump commands for PostgreSQL and they worked.