Repository navigation
fix: update web-media-effects version - #107
BlueLamantine wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d845611ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@webex/ts-events": "^1.2.1", | ||
| "@webex/web-capabilities": "^1.6.1", | ||
| "@webex/web-media-effects": "2.36.0", | ||
| "@webex/web-media-effects": "2.37.0", |
There was a problem hiding this comment.
Refresh AGENTS.md for the dependency pin
This changes the exact @webex/web-media-effects pin but leaves AGENTS.md with its pre-2.37 verification state. The root repository rule explicitly requires updating the agent guidance in the same PR whenever a package.json dependency pin changes, so refresh the applicable verification or compatibility guidance alongside this line.
AGENTS.md reference: AGENTS.md:L52-L52
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Description
Bumps
@webex/web-media-effectsfrom2.36.0to2.37.0.web-media-effects2.37.0 adds the effect Stats API (BaseEffect.getStats(),plus noise-reduction and virtual-background stats types) and an
EffectKindconstant.
BaseEffect.kindis now an abstract instance field on subclasses;load/dispose/replaceInputTrack/enableand thetrack-updated/disposedevents thatLocalStream.addEffectuses are unchanged.Consumers that want this pin need a published
webrtc-corecarrying it,otherwise their tree can resolve two copies of
web-media-effectsand twodistinct
BaseEffectclasses, which breaks type checking downstream.Test evidence (local, on this branch):
yarn transpile:validateyarn buildyarn test:lintyarn test:prettieryarn test:spellingyarn test:unitThis change implements...
Is this a breaking change?
I certify that...
Generative AI (GAI) Usage Disclosure
Reference: Cisco GAI Coding Guidelines
If a GAI tool/IDE was used then select the category that best describes GAI usage in this PR:
Additional GAI Usage Details (Optional):