Skip to content

fix: update web-media-effects version - #107

Closed
BlueLamantine wants to merge 1 commit into
mainfrom
vbuts/bump-media-effects-2.37.0
Closed

BlueLamantine wants to merge 1 commit into
mainfrom
vbuts/bump-media-effects-2.37.0

Conversation

@BlueLamantine

Copy link
Copy Markdown
Contributor

Description

Bumps @webex/web-media-effects from 2.36.0 to 2.37.0.
web-media-effects 2.37.0 adds the effect Stats API (BaseEffect.getStats(),
plus noise-reduction and virtual-background stats types) and an EffectKind
constant. BaseEffect.kind is now an abstract instance field on subclasses;
load / dispose / replaceInputTrack / enable and the track-updated /
disposed events that LocalStream.addEffect uses are unchanged.
Consumers that want this pin need a published webrtc-core carrying it,
otherwise their tree can resolve two copies of web-media-effects and two
distinct BaseEffect classes, which breaks type checking downstream.

Test evidence (local, on this branch):

check result
yarn transpile:validate clean
yarn build esm, cjs and umd bundles created
yarn test:lint no findings
yarn test:prettier no differences
yarn test:spelling 47 files checked, 0 issues
yarn test:unit 134 passed of 134, 8 suites

This change implements...

  • A new feature
  • A bug fix
  • Other (please specify): dependency version bump

Is this a breaking change?

  • Yes
  • No

I certify that...

  • All relevant unit and integration tests have passed and/or have been updated according to this change.

Generative AI (GAI) Usage Disclosure

Reference: Cisco GAI Coding Guidelines

  • Cisco approved GAI tool/IDE was used for coding - eg: VSCode, Cursor, Windsurf, Codex, Claude code
  • No GAI - Code was written entirely manually without GAI assistance

If a GAI tool/IDE was used then select the category that best describes GAI usage in this PR:

  • Manual Draft with GAI Refinement - I/we created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code) (Default)
  • GAI Draft with Manual Customization - GAI tool was used to create a draft that I/we subsequently customized or modified.
  • GAI Generated Code - Code was generated entirely by GAI

Additional GAI Usage Details (Optional):

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d845611ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
"@webex/ts-events": "^1.2.1",
"@webex/web-capabilities": "^1.6.1",
"@webex/web-media-effects": "2.36.0",
"@webex/web-media-effects": "2.37.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Refresh AGENTS.md for the dependency pin

This changes the exact @webex/web-media-effects pin but leaves AGENTS.md with its pre-2.37 verification state. The root repository rule explicitly requires updating the agent guidance in the same PR whenever a package.json dependency pin changes, so refresh the applicable verification or compatibility guidance alongside this line.

AGENTS.md reference: AGENTS.md:L52-L52

Useful? React with 👍 / 👎.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-14T10:18:45.082939Z 0d84561 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant