Repository navigation
Minimal builtin provider support + validation improvements - #142
Merged
Merged
Conversation
rgommers
reviewed
Sep 30, 2026
rgommers
left a comment
There was a problem hiding this comment.
This all looks sensible from a reading of the diff, and in line with the latest version of the PEP draft from what I can tell without more detailed testing.
I'll note that I am unlikely to have any time to review in detail in the next two weeks, and I wouldn't wait for me either way - I haven't touched this code a lot.
Member
|
I'll try to give it a look - I'm on PTO until Tuesday |
Collaborator
Author
Don't worry, I'm mostly adding all of you as FYI. |
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
mgorny
force-pushed
the
provider-builtin
branch
from
September 30, 2026 12:43
6c11fb8 to
baf8a5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
builtinproviders in the models; API functions reject them as unsupported.Fixed some random issues I've found while working on this:
build-requirestovariant.jsonwill raise an exception now.