Skip to content

Minimal builtin provider support + validation improvements - #142

Merged
mgorny merged 6 commits into
mainfrom
provider-builtin
Oct 2, 2026
Merged

mgorny merged 6 commits into
mainfrom
provider-builtin

Conversation

@mgorny

@mgorny mgorny commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Add support for builtin providers in the models; API functions reject them as unsupported.

Fixed some random issues I've found while working on this:

  1. Trying to export build-requires to variant.json will raise an exception now.
  2. All API functions now only load providers that are actually used.
  3. Variants without providers specified result in validation error rather than being silently ignored as incompatible.

@rgommers rgommers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks sensible from a reading of the diff, and in line with the latest version of the PEP draft from what I can tell without more detailed testing.

I'll note that I am unlikely to have any time to review in detail in the next two weeks, and I wouldn't wait for me either way - I haven't touched this code a lot.

@DEKHTIARJonathan

Copy link
Copy Markdown
Member

I'll try to give it a look - I'm on PTO until Tuesday

@mgorny

mgorny commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator Author

I'll note that I am unlikely to have any time to review in detail in the next two weeks, and I wouldn't wait for me either way - I haven't touched this code a lot.

Don't worry, I'm mostly adding all of you as FYI.

Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
@mgorny
mgorny merged commit 5dcca23 into main Oct 2, 2026
41 checks passed
@mgorny
mgorny deleted the provider-builtin branch October 2, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants