Repository navigation
Version 0.19.1 - #239
Merged
Merged
Version 0.19.1#239
Conversation
- Released `csshw 0.19.0` was unusable: `Failed to create process` panic on startup. The daemon/client spawn calls passed the hard-coded name `csshw.exe`, but the release workflow packaged the binary as `csshw.<version>.exe`, so `CreateProcess` could not find it. - `current_exe_path()` is added to the library; the two spawn sites in `cli.rs` and `daemon/mod.rs` now invoke the running binary by its actual path, so any rename (the version-stamped release artifact, or a user-renamed copy) works. - `release.yml` also stops renaming the exe inside the zip - the version stays in the archive filename only. With both fixes either change alone would unblock the user; together they are belt-and-braces. - `PKG_NAME` is kept for brand-string uses (window titles, `csshw-config.toml`, the named-pipe contract, clap's `argv[0]`). Those intentionally do not follow the binary's on-disk name. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
|
🤖 News Fragment Check ✅ Success! This PR meets the news fragment requirements. |
|
🤖 Diff Coverage Check ❌ Failed! Diff CoverageDiff: origin/main...HEAD, staged and unstaged changes
Summary
src/daemon/mod.rs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.