Skip to content

Version 0.19.1 - #239

Merged
whme merged 3 commits into
mainfrom
0.19-maintenance
May 23, 2026
Merged

whme merged 3 commits into
mainfrom
0.19-maintenance

Conversation

@whme

@whme whme commented May 23, 2026

Copy link
Copy Markdown
Owner

No description provided.

whme and others added 2 commits May 23, 2026 20:31
- Released `csshw 0.19.0` was unusable: `Failed to create process` panic
on startup. The daemon/client spawn calls passed the hard-coded name
`csshw.exe`, but the release workflow packaged the binary as
`csshw.<version>.exe`, so `CreateProcess` could not find it.
- `current_exe_path()` is added to the library; the two spawn sites in
`cli.rs` and `daemon/mod.rs` now invoke the running binary by its actual
path, so any rename (the version-stamped release artifact, or a
user-renamed copy) works.
- `release.yml` also stops renaming the exe inside the zip - the version
stays in the archive filename only. With both fixes either change alone
would unblock the user; together they are belt-and-braces.
- `PKG_NAME` is kept for brand-string uses (window titles,
`csshw-config.toml`, the named-pipe contract, clap's `argv[0]`). Those
intentionally do not follow the binary's on-disk name.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
@whme whme added the no-news-fragment-needed Indicates that this PR does not require a news fragment label May 23, 2026
@github-actions

Copy link
Copy Markdown

🤖 News Fragment Check

✅ Success! This PR meets the news fragment requirements.

@github-actions

Copy link
Copy Markdown

🤖 Diff Coverage Check

❌ Failed!

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

  • src/cli.rs (100%)
  • src/daemon/mod.rs (0.0%): Missing lines 1536-1537
  • src/lib.rs (100%)

Summary

  • Total: 9 lines
  • Missing: 2 lines
  • Coverage: 77%

src/daemon/mod.rs

  1532     }
  1533     client_args.push("client".to_string());
  1534     client_args.extend(vec!["--".to_string(), actual_host.to_string()]);
  1535 
! 1536     let process_info = spawn_console_process(windows_api, &current_exe_path(), client_args, false)
! 1537         .expect("Failed to create process");
  1538     let client_window_handle = get_console_window_handle(windows_api, process_info.dwProcessId);
  1539     let process_handle = windows_api
  1540         .open_process(PROCESS_QUERY_INFORMATION.0, false, process_info.dwProcessId)
  1541         .unwrap_or_else(|err| {

@whme
whme marked this pull request as ready for review May 23, 2026 18:49
@whme
whme merged commit e31e6e1 into main May 23, 2026
12 of 14 checks passed
@whme
whme deleted the 0.19-maintenance branch May 23, 2026 18:50
@whme
whme restored the 0.19-maintenance branch May 23, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-news-fragment-needed Indicates that this PR does not require a news fragment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant